Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v2 engine add univar parts #63

Merged
merged 12 commits into from Sep 22, 2021
Merged

feat: v2 engine add univar parts #63

merged 12 commits into from Sep 22, 2021

Conversation

ObservedObserver
Copy link
Member

new feats are implements in visual-insights@0.6.2

@todo
Copy link

todo bot commented Sep 22, 2021

FIX this in visual insights

// @ts-ignore TODO: FIX this in visual insights
const { cube, fieldDictonary } = context;
const { dimensions, measures } = viewSpace;
const cuboid = cube.getCuboid(viewSpace.dimensions);
const aggData = cuboid.getState(measures, measures.map(() => 'sum'));
const insightSpaces: IInsightSpace[] = []


This comment was generated by todo based on a TODO comment in 1ba6d57 in #63. cc @Kanaries.

@todo
Copy link

todo bot commented Sep 22, 2021

FIXME '(group)'

// TODO: FIXME '(group)'
function mergeFields (originFields: IRawField[], transedFields: Field[]): BIField[] {
return originFields.map(oF => {
let nF = transedFields.find(tF => tF.name === oF.fid + '(group)')
return {
name: nF ? nF.name : oF.fid,


This comment was generated by todo based on a TODO comment in 1ba6d57 in #63. cc @Kanaries.

@todo
Copy link

todo bot commented Sep 22, 2021

Rath和VI中都有一套,弱约束关联,可能带来潜在的迭代负担或bug

// TODO: Rath和VI中都有一套,弱约束关联,可能带来潜在的迭代负担或bug
import { IAnalyticType, ISemanticType } from 'visual-insights/build/esm/insights/InsightFlow/interfaces';
export function isASCII(str: string) {
return /^[\x00-\x7F]*$/.test(str)
}


This comment was generated by todo based on a TODO comment in 1ba6d57 in #63. cc @Kanaries.

@todo
Copy link

todo bot commented Sep 22, 2021

推断逻辑抽象一下

// TODO: 推断逻辑抽象一下
return !isNaN(Number(row[fid])) || row[fid] === undefined
})
? 'measure'
: 'dimension'
}


This comment was generated by todo based on a TODO comment in 1ba6d57 in #63. cc @Kanaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant