Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use spec_io_mode instead of debug parameter #472

Merged
merged 1 commit into from Mar 8, 2024

Conversation

longxiaofei
Copy link
Member

@longxiaofei longxiaofei commented Mar 8, 2024

The previous 'debug' parameter was only used to restrict the ability to read and write spec files. We believe this parameter name is not meaningful, and we are replacing it with 'spec_io_mode.'

The 'spec_io_mode' parameter currently has two options: 'r' and 'wr,' where 'r' indicates that the spec is read-only, and 'wr' indicates that spec files can be saved.

previous:

StreamlitRenderer(df, spec="./gw_config.json", debug=True)

current:

StreamlitRenderer(df, spec="./gw_config.json", spec_io_mode="rw")

@longxiaofei longxiaofei merged commit ceced0b into Kanaries:main Mar 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant