Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support masking password type field #503

Closed
igarashitm opened this issue Dec 5, 2023 · 4 comments · Fixed by #1059
Closed

Support masking password type field #503

igarashitm opened this issue Dec 5, 2023 · 4 comments · Fixed by #1059
Assignees
@igarashitm
Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Milestone
2.0.0

Comments

@igarashitm
Copy link
Contributor

Please describe the feature that you want to propose

cf. #497 (comment)

Some of the official kamelets have format: password in its parameter definition. It is already passed into propertiesSchema in Kaoto.

However, uniforms seems not leverage it to make TextInput to have type=password.
https://github.com/KaotoIO/uniforms-patternfly/blob/081136eb61576f18b7bb437bb01ec29b901ce066/src/TextField.tsx#L118-L126
Here it should do

if (props.field.format === 'password') return 'password'
@igarashitm igarashitm added canvas/config-form Configuration form related issues enhancement New feature or request labels Dec 5, 2023
@lordrip
Copy link
Member

lordrip commented Dec 5, 2023

We also need to be able to unmask the field to write placeholders on it.

@lordrip lordrip added this to the 2.1.0 milestone Dec 5, 2023
@igarashitm igarashitm mentioned this issue Dec 8, 2023
Closed
@lhein lhein removed this from the 2.0.0 milestone Feb 1, 2024
@lhein
Copy link
Contributor

lhein commented Apr 4, 2024

related to #285 ?

@lordrip
Copy link
Member

lordrip commented Apr 4, 2024

Yes, related

@lhein
Copy link
Contributor

lhein commented Apr 30, 2024

https://www.patternfly.org/components/password-generator

@lhein lhein added this to the 2.0.0 milestone Apr 30, 2024
@igarashitm igarashitm self-assigned this May 2, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
e0c0eaa 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
@igarashitm igarashitm mentioned this issue May 3, 2024
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
331fc5f 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
31b15eb 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
54b4425 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Projects
Kanban Board
Archived in project
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

fix: Add PasswordField to mask input value of the field with `format:… igarashitm/kaoto
3 participants
@igarashitm @lhein @lordrip