fix(Catalog): Using labels causes unintended navigation #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: Currently, we're using the `numLabels` property of the `LabelGroup` component to show just a few `Labels`. When the user clicks on the `n more` label, a navigation is performed and the UI is reloaded, causing the VSCode extension to fail. This happens because `LabelGroup` is a child of the `Form` component, causing to execute the default Form behavior when selecting a `Label` Changes: The fix is to move the Label bar outside of the `Form` component. fix: KaotoIO#1073 fix: KaotoIO#1074
apupier
reviewed
May 13, 2024
|
@apupier, I agree with you, but in this case, the fix for the category issue broke the styling of the filter bar, so I ended up with two scenarios:
I decided for the later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, we're using the
numLabelsproperty of theLabelGroupcomponent to show just a fewLabels.When the user clicks on the
n morelabel, a navigation is performed and the UI is reloaded, causing the VSCode extension to fail.This happens because
LabelGroupis a child of theFormcomponent, causing to execute the default Form behavior when selecting aLabelChanges
The fix is to move the Label bar outside of the
Formcomponent.Screenshot
fix: #1073
fix: #1074
fix: #911