Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List layout button in catalog is cropped #1074

Closed
apupier opened this issue May 13, 2024 · 0 comments · Fixed by #1078
Closed

List layout button in catalog is cropped #1074

apupier opened this issue May 13, 2024 · 0 comments · Fixed by #1078
Labels
bug Something isn't working catalog Catalog-related issues good first issue Good for newcomers help wanted Extra attention is needed ui/ux This issue is about improving the UI / UX

Comments

@apupier
Copy link
Member

apupier commented May 13, 2024

Describe the Bug

one button is cropped at the top right of the catalog modal dialog

Steps to Reproduce the Bug or Issue

  1. create a camel route
  2. click on append

Screenshots or Videos

image

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: 2.0-RC1
@apupier apupier added the bug Something isn't working label May 13, 2024
@lhein lhein added good first issue Good for newcomers help wanted Extra attention is needed catalog Catalog-related issues ui/ux This issue is about improving the UI / UX labels May 13, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue May 13, 2024
@lordrip
fix(Catalog): Using labels causes unintended navigation
0753404 
Context:
Currently, we're using the `numLabels` property of the `LabelGroup` component to show just a few `Labels`.

When the user clicks on the `n more` label, a navigation is performed and the UI is reloaded, causing the VSCode extension to fail.

This happens because `LabelGroup` is a child of the `Form` component, causing to execute the default Form behavior when selecting a `Label`

Changes:
The fix is to move the Label bar outside of the `Form` component.

fix: KaotoIO#1073
fix: KaotoIO#1074
@lordrip lordrip mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working catalog Catalog-related issues good first issue Good for newcomers help wanted Extra attention is needed ui/ux This issue is about improving the UI / UX
Projects
Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Catalog): Using labels causes unintended navigation lordrip/kaoto
2 participants
@lhein @apupier