Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1216): Expressions should be shown similar to data formats in the… #1275

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jul 29, 2024

… config panel

fixes #1216

Sample running at: https://tplevko.github.io/kaoto-next/

@tplevko tplevko force-pushed the issue_1216 branch 9 times, most recently from 77b7ad2 to 0a777b3 Compare July 31, 2024 08:58
@tplevko
Copy link
Contributor Author

tplevko commented Jul 31, 2024

The second part of the issue #1216 Preset "Simple" as the default selected expression language already done here - #1068

@tplevko tplevko force-pushed the issue_1216 branch 5 times, most recently from 408063d to 658ef84 Compare August 6, 2024 08:40
@tplevko tplevko marked this pull request as ready for review August 6, 2024 10:29
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tplevko, thanks for taking care. ✌️

@@ -1,21 +1,22 @@
import catalogLibrary from '@kaoto/camel-catalog/index.json';
import { CatalogLibrary } from '@kaoto/camel-catalog/types';
import { act, fireEvent, render, screen } from '@testing-library/react';
import { SchemaService } from '..';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { SchemaService } from '..';
import { SchemaService } from '../schema.service';

@lhein
Copy link
Contributor

lhein commented Aug 6, 2024

Looks great!

@lordrip lordrip merged commit 6b70658 into KaotoIO:main Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expressions should be shown similar to data formats in the config panel
3 participants