Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder image: Ports debug Vertx app to Reactive, bumps Q versions #230

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Builder image: Ports debug Vertx app to Reactive, bumps Q versions #230

merged 1 commit into from
Nov 29, 2023

Conversation

Karm
Copy link
Owner

@Karm Karm commented Nov 28, 2023

fixes #78
fixes #229

@Karm
Copy link
Owner Author

Karm commented Nov 28, 2023

Ah, forgot about that one. Gonna fix.

@zakkak
Copy link
Collaborator

zakkak commented Nov 28, 2023

There are still some warnings that need to be whitelisted:

Warning: The option '-H:-ParseOnce' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:BuildOutputJSONFile=quarkus-json_plus-ParseOnce.json' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:BuildOutputJSONFile=quarkus-json_minus-ParseOnce.json' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:+ParseOnce' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future. ==> expected: <true> but was: <false>

zakkak
zakkak approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the warnings that need whitelisting

@Karm
Ports builder image debug Vertx app to Reactive
d1979a8 
Q version and M version bumps for local tests
@Karm
Copy link
Owner Author

Karm commented Nov 28, 2023

There are still some warnings that need to be whitelisted:

Warning: The option '-H:-ParseOnce' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:BuildOutputJSONFile=quarkus-json_plus-ParseOnce.json' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:BuildOutputJSONFile=quarkus-json_minus-ParseOnce.json' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future.
Warning: The option '-H:+ParseOnce' is experimental and must be enabled via '-H:+UnlockExperimentalVMOptions' in the future. ==> expected: <true> but was: <false>

I am wrapping them in unlock...

@Karm
Copy link
Owner Author

Karm commented Nov 29, 2023

All green, wow :)

@Karm Karm merged commit 5f54eb5 into master Nov 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Karm @zakkak