Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JFR whitelisted log lines #238

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update JFR whitelisted log lines #238

merged 3 commits into from
Dec 18, 2023

Conversation

roberttoyonaga
Copy link
Collaborator

@roberttoyonaga roberttoyonaga commented Dec 18, 2023 •
edited by jerboaa
Loading

Closes: #239

@roberttoyonaga roberttoyonaga self-assigned this Dec 18, 2023
@roberttoyonaga roberttoyonaga marked this pull request as draft December 18, 2023 14:49
zakkak
zakkak approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I would wait for 8037 to be merged before whitelisting the @Deprecated JFR events part.

@roberttoyonaga roberttoyonaga marked this pull request as ready for review December 18, 2023 15:49
@jerboaa jerboaa linked an issue Dec 18, 2023 that may be closed by this pull request
JFR StackFilters are not yet supported. Allow list them. #239
Closed
jerboaa
jerboaa approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jerboaa jerboaa merged commit 9117e41 into Karm:master Dec 18, 2023
19 checks passed
@roberttoyonaga roberttoyonaga mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

@zakkak zakkak zakkak approved these changes

@Karm Karm Awaiting requested review from Karm

Assignees

@roberttoyonaga roberttoyonaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JFR StackFilters are not yet supported. Allow list them.
3 participants
@roberttoyonaga @jerboaa @zakkak