Relationship labels #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangoslen
commented
Sep 30, 2023
.go-version
Outdated
There was a problem hiding this comment.
This can be helpful for users of goenv
dangoslen
commented
Sep 30, 2023
config/relationship_label.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| var labelRegex = regexp.MustCompile(`([\w\._-]+)[\s]+([\w\._-]+)[\s]+:[\s]+([\w._-]+)`) |
There was a problem hiding this comment.
Will add comments here for the details of the regex
dangoslen
commented
Oct 1, 2023
diagram/diagram.go
Outdated
| @@ -59,12 +59,13 @@ func (d diagram) Create(result *database.Result) error { | |||
| } | |||
|
|
|||
| var constraints []ErdConstraintData | |||
| relationshipLabelMap := BuildRelationshipLabelMap(d.config) | |||
There was a problem hiding this comment.
Building the map is O(n) and we then get (essentially) O(1) lookup times when finding a constraint later vs doing a O(n) linear search each time
KarnerTh
approved these changes
Nov 1, 2023
KarnerTh
pushed a commit
that referenced
this pull request
Nov 18, 2023
* Support multiple key constraints on a single attribute (#51) * Add unique constraint to key column (#43) * Relationship labels (#50) * Adds relationship label types and parser * Lookup label based on pk and fk names; overrides omitting the label and the constraint label * First full working version * Use a map for faster lookup * Fix example labels * Adds comments for label regex * Adds basic tests for relationship label map * Support multiple key constraints on a single attribute (#51) (#52) * Add unique constraint to key column (#43) --------- Co-authored-by: Dan Goslen <dwgoslen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #48, though, without supporting the flag in the command line. That seemed like it would be too tedious for a user anyway
I'm considering using a YAML map instead of an array, though it would require using a complex key. I'm open to whichever you prefer
I also plan to refactor the
RelationshipLabelsto become a map for better runtime lookup.