Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVP Stats Tracking Rebase #206

Merged
merged 1 commit into from
Dec 5, 2020
Merged

PVP Stats Tracking Rebase #206

merged 1 commit into from
Dec 5, 2020

Conversation

PoGoJoshS
Copy link
Contributor

@PoGoJoshS PoGoJoshS commented Dec 3, 2020

Description

Rebase of #151 created by @123FLO321 that also solves a simple merge conflict.

• Only works with RDM (since others don't send PVP stats) and requires RDM PR 120
• Adds options to track based on Great and Ultra League PVP stats rank.
◦ !track snorlax great1 for top 1 great league snorlax
◦ !track everything great1 greatcp1450 for top 1 great league pokemon maxing out at or above 1450CP
◦ !track snorlax ultra100 for top 100 ultra league snorlax
◦ !track everything ultra1 ultracp2400 for top 1 great league pokemon maxing out at or above 2400CP
◦ Do not combine greatX and ultraX in same tracking command because that would require BOTH to be true
• Adds new bestGreatLeagueRank and bestUltraLeagueRank DTS
• No longer perform a git clone in the Dockerfile

TODO: - Add examples to help command

Motivation and Context

Utilize RDMs PVP Stats being via WebHook (RealDeviceMap/RealDeviceMap#120)

How Has This Been Tested?

Tested by multiple people in production environment for months.

Example DTS:

Great League (formatted for readability, remove line brakes)

{{#if pvp_rankings_great_league}}**Great League:**\n
{{#each pvp_rankings_great_league}}
 - {{pokemonName this.pokemon}} #{{this.rank}} @{{this.cp}}CP (Lvl. {{this.level}})\n
{{/each}}
{{/if}}

Ultra League (formatted for readability, remove line brakes)

{{#if pvp_rankings_ultra_league}}**Ultra League:**\n
{{#each pvp_rankings_ultra_league}}
- {{pokemonName this.pokemon}} #{{this.rank}} @{{this.cp}}CP (Lvl. {{this.level}})\n
{{/each}}
{{/if}}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Re-base of PR151 created by 123FLO321.
@jfberry jfberry merged commit 05d8cc3 into KartulUdus:develop Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants