Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #KLI-55 直進・後退に関するクラスの作成 #16

Merged
merged 9 commits into from
Jun 26, 2024
Merged

close #KLI-55 直進・後退に関するクラスの作成 #16

merged 9 commits into from
Jun 26, 2024

Conversation

bizyutyu
Copy link
Collaborator

@bizyutyu bizyutyu commented Jun 19, 2024 •
edited
Loading

チェックリスト

  • clang-format している
  • コーディング規約に準じている
  • チケットの完了条件を満たしている

変更点

  • 直進・後退に関する以下のクラスを作成し、module/Motion/に追加。
    • 親クラス（Straight.h, Straight.cpp）
    • 子クラス
      • 色指定直進（ColorStraight.h, ColorStraight.cpp）
      • 距離指定直進（DistanceStraight.h, DistanceStraight.cpp）
  • 上記子クラスのテストをtest/に追加

動作テスト

https://www.notion.so/uom-katlab/38ee60e3882545f49a9c00c1f53852eb?pvs=4

@notion-workspace Notion Workspace
Copy link

直進の親子クラス作成(距離指定, 色指定)

@bizyutyu bizyutyu self-assigned this Jun 19, 2024
@bizyutyu bizyutyu marked this pull request as ready for review June 23, 2024 01:42
@bizyutyu bizyutyu requested a review from a team June 23, 2024 12:21
CHIHAYATAKU
CHIHAYATAKU requested changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@CHIHAYATAKU CHIHAYATAKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LineTracingとStraightで合わせたいので，よろしくお願いします．
どちらかに合わせたほうが良いと思うので，合わせるまでは一応Recested Changeで出しておきます．

module/Motion/DistanceStraight.cpp Outdated Show resolved Hide resolved
module/Motion/ColorStraight.cpp Outdated Show resolved Hide resolved
module/Motion/DistanceStraight.cpp Outdated Show resolved Hide resolved
module/Motion/Straight.h Outdated Show resolved Hide resolved
aridome222
aridome222 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@aridome222 aridome222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHIHAYATAKU
CHIHAYATAKU approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@CHIHAYATAKU CHIHAYATAKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

話し合って決めることができたのでよかったです！
僕は問題ないと思います
LGTM

negiuniv
negiuniv approved these changes Jun 25, 2024
View reviewed changes
Copy link

@negiuniv negiuniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KakinokiKanta
KakinokiKanta approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@KakinokiKanta KakinokiKanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなってしまい、申し訳ない。
LGTM

@YKhm20020 YKhm20020 merged commit bb27498 into main Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KakinokiKanta KakinokiKanta KakinokiKanta approved these changes

@aridome222 aridome222 aridome222 approved these changes

@negiuniv negiuniv negiuniv approved these changes

@CHIHAYATAKU CHIHAYATAKU CHIHAYATAKU approved these changes

Assignees

@bizyutyu bizyutyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bizyutyu @KakinokiKanta @aridome222 @negiuniv @CHIHAYATAKU @YKhm20020