Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add busy-waiting option to BFS/SSSP #307

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Add busy-waiting option to BFS/SSSP #307

merged 2 commits into from
Jun 17, 2021

Conversation

nicelhc13
Copy link
Contributor

No description provided.

roshandathathri
roshandathathri approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@roshandathathri roshandathathri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arthurp
arthurp reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@arthurp arthurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thread_spin should be a part of the plan if it's passed to the algorithm at all.

What if instead of this we had a way to set it from Python directly like how we can call set_active_threads()? Then we wouldn't need to do it for each algothm.

@nicelhc13
Copy link
Contributor Author

thread_spin should be a part of the plan if it's passed to the algorithm at all.

What if instead of this we had a way to set it from Python directly like how we can call set_active_threads()? Then we wouldn't need to do it for each algothm.

Sure, that's a good idea, but let's do that at the next PR.

@nicelhc13 nicelhc13 merged commit 0491b35 into KatanaGraph:master Jun 17, 2021
@nicelhc13 nicelhc13 deleted the benchmark/spin-lock branch June 23, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurp arthurp arthurp left review comments

@roshandathathri roshandathathri roshandathathri approved these changes

@amberhassaan amberhassaan Awaiting requested review from amberhassaan

@ddn0 ddn0 Awaiting requested review from ddn0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicelhc13 @arthurp @roshandathathri