Skip to content

Commit

Permalink
Sync merge with develop
Browse files Browse the repository at this point in the history
Merge remote-tracking branch 'origin/develop' into feature/monitor_jobs_separate

* origin/develop:
  Fix path for marine products (NOAA-EMC#1966)
  Build GDASapp for CI tests (NOAA-EMC#1964)
  Updates for NOAA CSP AWS global-workflow related file paths. (NOAA-EMC#1970)
  Set SENDCOM=YES for tracker/genesis tasks (NOAA-EMC#1971)
  Refactor UFSDA ATM var and ens layout (NOAA-EMC#1945)
  Optimize the checkout script (NOAA-EMC#1956)
  Fix nth_eupd in gfs/config.resources.  remove sections of jobs not run as part of gefs from gefs/config.resources (NOAA-EMC#1952)
  Fix enkfgfs cleanup dependency (NOAA-EMC#1941)
  Split clean-up into separate job (NOAA-EMC#1906)
  • Loading branch information
KateFriedman-NOAA committed Oct 25, 2023
2 parents d0ec662 + e817f5d commit 9f04da8
Show file tree
Hide file tree
Showing 25 changed files with 261 additions and 811 deletions.
4 changes: 2 additions & 2 deletions ci/scripts/check_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ for pr in ${pr_list}; do
# Check to see if this PR that was opened by the weekly tests and if so close it if it passed on all platforms
weekly_labels=$(${GH} pr view "${pr}" --repo "${REPO_URL}" --json headRefName,labels,author --jq 'select(.author.login | contains("emcbot")) | select(.headRefName | contains("weekly_ci")) | .labels[].name ') || true
if [[ -n "${weekly_labels}" ]]; then
num_platforms=$(find ../platforms -type f -name "config.*" | wc -l)
num_platforms=$(find "${ROOT_DIR}/ci/platforms" -type f -name "config.*" | wc -l)
passed=0
for platforms in ../platforms/config.*; do
for platforms in "${ROOT_DIR}"/ci/platforms/config.*; do
machine=$(basename "${platforms}" | cut -d. -f2)
if [[ "${weekly_labels}" == *"CI-${machine^}-Passed"* ]]; then
((passed=passed+1))
Expand Down
2 changes: 1 addition & 1 deletion ci/scripts/clone-build_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ echo "${commit}" > "../commit"
cd sorc || exit 1
set +e
# TODO enable -u later when GDASApp tests are added
./checkout.sh -c -g >> log.checkout 2>&1
./checkout.sh -c -g -u >> log.checkout 2>&1
checkout_status=$?
if [[ ${checkout_status} != 0 ]]; then
{
Expand Down
4 changes: 2 additions & 2 deletions docs/source/noaa_csp.rst
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,14 @@ the global-workflow.

The software stack supporting the ``develop`` branch of the
global-workflow is provided for the user and is located beneath
``/contrib/global-workflow/spack-stack``. The modules required for the
``/contrib/emc_static/spack-stack``. The modules required for the
global-workflow execution may be loaded as follows.

.. code-block:: bash
user@host:$ module unuse /opt/cray/craype/default/modulefiles
user@host:$ module unuse /opt/cray/modulefiles
user@host:$ module use /contrib/global-workflow/spack-stack/miniconda/modulefiles/miniconda
user@host:$ module use /contrib/emc_static/spack-stack/miniconda/modulefiles/miniconda
user@host:$ module load py39_4.12.0
user@host:$ module load rocoto/1.3.3
Expand Down
17 changes: 17 additions & 0 deletions jobs/JGLOBAL_CLEANUP
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#! /usr/bin/env bash

source "${HOMEgfs}/ush/preamble.sh"
source "${HOMEgfs}/ush/jjob_header.sh" -e "cleanup" -c "base cleanup"

"${HOMEgfs}/scripts/exglobal_cleanup.sh"
status=$?
[[ ${status} -ne 0 ]] && exit "${status}"

##########################################
# Remove the Temporary working directory
##########################################
cd "${DATAROOT}" || (echo "${DATAROOT} does not exist. ABORT!"; exit 1)
[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}"

exit 0

1 change: 0 additions & 1 deletion jobs/rocoto/arch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ export jobid="${job}.$$"
"${HOMEgfs}"/jobs/JGLOBAL_ARCHIVE
status=$?


exit "${status}"
19 changes: 19 additions & 0 deletions jobs/rocoto/cleanup.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#! /usr/bin/env bash

source "${HOMEgfs}/ush/preamble.sh"

###############################################################
# Source FV3GFS workflow modules
. "${HOMEgfs}"/ush/load_fv3gfs_modules.sh
status=$?
[[ ${status} -ne 0 ]] && exit "${status}"

export job="cleanup"
export jobid="${job}.$$"

###############################################################
# Execute the JJOB
"${HOMEgfs}"/jobs/JGLOBAL_CLEANUP
status=$?

exit "${status}"
2 changes: 1 addition & 1 deletion jobs/rocoto/ocnpost.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ YMD=${PDY} HH=${cyc} generate_com -rx COM_OCEAN_HISTORY COM_OCEAN_2D COM_OCEAN_3
COM_OCEAN_XSECT COM_ICE_HISTORY

for grid in "0p50" "0p25"; do
YMD=${PDY} HH=${cyc} GRID=${grid} generate_com -rx "COM_OCEAN_GRIB_${grid}:COM_OCEAN_GRIB_TMPL"
YMD=${PDY} HH=${cyc} GRID=${grid} generate_com -rx "COM_OCEAN_GRIB_${grid}:COM_OCEAN_GRIB_GRID_TMPL"
done

for outdir in COM_OCEAN_2D COM_OCEAN_3D COM_OCEAN_XSECT COM_OCEAN_GRIB_0p25 COM_OCEAN_GRIB_0p50; do
Expand Down
Loading

0 comments on commit 9f04da8

Please sign in to comment.