fixes #14615 - update api calls for hosts #26

thomasmckay · 2016-07-07T17:41:37Z

No description provided.

beav · 2016-07-07T22:02:58Z

lib/hammer_cli_import/base.rb

        debug "created entity: #{entity.inspect}"
        entity = entity[@wrap_in[entity_type]] if @wrap_in[entity_type]
-        # workaround for Bug
-        entity['id'] = entity['uuid'] if entity_type == :systems


I'm not all that familiar with this code. Why is it ok to remove this?

yes, systems used to use the candlepin uuid as the id

beav · 2016-07-07T22:11:48Z

I get the following output:

I, [2016-07-07T21:58:45.021201 #17150]  INFO -- : Importing from users.csv
I, [2016-07-07T21:58:45.021533 #17150]  INFO -- : Creating new organization: Satellite QE
I, [2016-07-07T21:58:46.969411 #17150]  INFO -- : Creating new organization: Organization #2
I, [2016-07-07T21:58:48.426187 #17150]  INFO -- : Creating new organization: Organization #3
I, [2016-07-07T21:58:49.809465 #17150]  INFO -- : Summary
I, [2016-07-07T21:58:49.809518 #17150]  INFO -- :   Created 3 organizations.
I, [2016-07-07T22:06:11.640302 #17607]  INFO -- : Importing from system-profiles.csv
E, [2016-07-07T22:06:11.641101 #17607] ERROR -- : Unable to import, first import content view with id 103
E, [2016-07-07T22:06:11.641310 #17607] ERROR -- : Unable to import, first import content view with id 101
E, [2016-07-07T22:06:11.641573 #17607] ERROR -- : Unable to import, first import content view with id 102
I, [2016-07-07T22:06:11.641675 #17607]  INFO -- : Summary
I, [2016-07-07T22:06:11.641714 #17607]  INFO -- :   No action taken.

it doesn't 500, but after running the import I don't see any hosts in my host list

thomasmckay · 2016-07-07T22:35:02Z

yeah, you'll need to run the 'hammer import XYZ' steps individually i think

beav · 2016-07-08T00:51:57Z

I ran the steps using the example export you gave me and got past the 500 error. I was not able to get all the way through since the URLs in the repositories.csv file didn't point to repos I had access to. I do not have commit privs on this repo but the change looks good to me.

lpramuk · 2016-11-23T09:47:02Z

lib/hammer_cli_import/base.rb

+      password = (HammerCLI::Settings.settings[:_params] &&
+                  HammerCLI::Settings.settings[:_params][:password]) ||
+        HammerCLI::Settings.get(:foreman, :password)
+      @api = ApipieBindings::API.new({


This is problematic part. What if user is being asked for password?

fixes #14615 - update api calls for hosts

0054259

beav reviewed Jul 7, 2016
View reviewed changes

thomasmckay merged commit cdd92c6 into Katello:master Jul 8, 2016

thomasmckay deleted the 14615-hosts branch July 8, 2016 13:17

lpramuk reviewed Nov 23, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #14615 - update api calls for hosts #26

fixes #14615 - update api calls for hosts #26

thomasmckay commented Jul 7, 2016

beav Jul 7, 2016

thomasmckay Jul 7, 2016

beav commented Jul 7, 2016

thomasmckay commented Jul 7, 2016

beav commented Jul 8, 2016

lpramuk Nov 23, 2016 •

edited

Loading

fixes #14615 - update api calls for hosts #26

fixes #14615 - update api calls for hosts #26

Conversation

thomasmckay commented Jul 7, 2016

beav Jul 7, 2016

Choose a reason for hiding this comment

thomasmckay Jul 7, 2016

Choose a reason for hiding this comment

beav commented Jul 7, 2016

thomasmckay commented Jul 7, 2016

beav commented Jul 8, 2016

lpramuk Nov 23, 2016 • edited Loading

Choose a reason for hiding this comment

lpramuk Nov 23, 2016 •

edited

Loading