This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Fixes #15781 - add ssl_cert_file to env check #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
suggested changes
Sep 22, 2016
|
|
||
| variables = %w(http_proxy https_proxy ssl_cert_file) | ||
|
|
||
| if variables.map{ |variable| ENV[variable] }.compact.any? |
There was a problem hiding this comment.
rubocop wants a space between map and {
ekohl
reviewed
Sep 22, 2016
|
|
||
| if variables.map{ |variable| ENV[variable] }.compact.any? | ||
| $stderr.puts "Please unset the following environment variables before running the installer: #{variables.join(', ')}" | ||
| exit 1 |
|
Thanks for the review @ekohl ! |
ekohl
approved these changes
Sep 22, 2016
johnpmitsch
pushed a commit
to johnpmitsch/katello-installer
that referenced
this pull request
Oct 4, 2016
(cherry picked from commit 9b9daf3)
johnpmitsch
pushed a commit
to johnpmitsch/katello-installer
that referenced
this pull request
Oct 4, 2016
(cherry picked from commit 9b9daf3)
zjhuntin
added a commit
to zjhuntin/katello-installer
that referenced
this pull request
Oct 30, 2018
Adds hammer-foreman repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.