This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Host::Register` tasks have been removed as part of Katello/katello#7082. This change adds a step to remove all tasks with label `Actions::Katello::Host::Register`. Without this, already-executed tasks will show as blank in the web UI. (cherry picked from commit f113791)
Issues: #21703 |
chris1984
approved these changes
Feb 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zjhuntin
force-pushed
the
cherry_picks
branch
2 times, most recently
from
March 6, 2018 21:58
d045ae3
to
3f50dff
Compare
ehelms
reviewed
Mar 6, 2018
Puppetfile
Outdated
# A fork that marks metadata as compatible with puppet 5 | ||
# https://github.com/thias/puppet-squid3/pull/59 | ||
mod 'thias-squid3', :git => 'https://github.com/theforeman/puppet-squid3', :ref => 'allow-puppet-5' | ||
forge 'https://forgeapi.puppetlabs.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isnt needed
(cherry picked from commit b6f6141)
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
Should the title be just RC2 cherry picks? |
ehelms
changed the title
Refs #21703 - remove registration tasks
Katello 3.6 RC2 cherry picks
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host::Register
tasks have been removed as part ofKatello/katello#7082.
This change adds a step to remove all tasks with label
Actions::Katello::Host::Register
. Without this, already-executed tasks willshow as blank in the web UI.
(cherry picked from commit f113791)