Refs #23190 - replace .uniq with .distinct

Katello · Apr 12, 2018 · 458b610 · 458b610
1 parent 6d7ca7c
commit 458b610
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/app/models/katello/content_view.rb b/app/models/katello/content_view.rb
@@ -353,16 +353,6 @@ def products(env = nil)
       Product.joins(:repositories).where("#{Katello::Repository.table_name}.id" => repos.map(&:id)).distinct
     end
 
-    def version_products(env)
-      repos = repos(env)
-      Product.joins(:repositories).where("#{Katello::Repository.table_name}.id" => repos.map(&:id)).distinct
-    end
-
-    #list all products associated to this view across all versions
-    def all_version_products
-      Product.joins(:repositories).where("#{Katello::Repository.table_name}.id" => self.all_version_repos).distinct
-    end
-
     #get the library instances of all repos within this view
     def all_version_library_instances
       all_repos = all_version_repos.where(:library_instance_id => nil).pluck("#{Katello::Repository.table_name}.id")

diff --git a/test/models/content_view_test.rb b/test/models/content_view_test.rb
@@ -391,6 +391,11 @@ def test_add_repository_from_other_org
       end
     end
 
+    def test_products
+      refute_empty @library_view.products
+      refute_empty @library_View.products.redhat
+    end
+
     def test_add_repository_from_other_view
       view = @library_view
       bad_repo = Repository.find(katello_repositories(:fedora_17_x86_64_library_view_1).id)