Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #34760 - Hide profiles for module streams #10060

Merged
merged 1 commit into from Apr 14, 2022

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Apr 12, 2022

What are the changes introduced in this pull request?

Hide Module Stream profiles from UI/Hammer/API since we don't have that data anymore.

Considerations taken when implementing this change?

Pulp no longer provides the profile information for module streams for katello to index.
We have an issue open for pulp to consider adding it pulp/pulp_rpm#2456
In the meantime, we should hide user-facing profile details since it's empty.

What are the testing steps for this pull request?

On UI:

Sync a repo with modules.
Go to > Content > Module Streams > module_stream_record
You shouldn't see the profiles tab.
Also check the breadcrumb bar. Due to some changes in foreman, the breadcrumb on the module stream page had stopped working.

In hammer
hammer -r module-stream info --id 1
should not show profile section anymore.

@theforeman-bot
Copy link

Issues: #34760

@sjha4 sjha4 force-pushed the hide_module_stream_profiles branch from b58ffab to 249d350 Compare April 12, 2022 13:35
@chris1984 chris1984 self-assigned this Apr 14, 2022
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK,

Works great hammer output:

[vagrant@centos7-hammer-devel ~]$ hammer -r module-stream info --id 1
Id:                 1
Module Stream Name: walrus
Stream:             5.21
Uuid:               /pulp/api/v3/content/rpm/modulemds/b2900713-6980-4de9-9258-ff829b531b49/
Version:            20180704144203
Architecture:       x86_64
Context:            deadbeef
Repositories:       
 1) Id:   1
    Name: Food
Artifacts:          
 1) Id:   1
    Name: walrus-0:5.21-1.noarch

Profile section is gone under the Content -> Module Streams tab. Tested the breadcrumbs on the new host detail and was able to see other hosts and go back to all hosts.

Do you think it's worth making a migration to remove the katello_module_profiles table or just keep it since there is an rfe open against Pulp?

@sjha4
Copy link
Member Author

sjha4 commented Apr 14, 2022

Do you think it's worth making a migration to remove the katello_module_profiles table or just keep it since there is an rfe open against Pulp?

We are not entirely removing the data model and data right away cause we want to see the resolution on the pulp issue. If we can refactor the code a little based on pulp implementation in the future to support it, it'd be nice.

@chris1984
Copy link
Member

ship it 👍

@sjha4 sjha4 merged commit 3afbe21 into Katello:master Apr 14, 2022
jeremylenz pushed a commit to jeremylenz/katello that referenced this pull request Apr 25, 2022
ianballou pushed a commit to ianballou/katello that referenced this pull request May 24, 2022
ianballou pushed a commit that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants