Fixes #35012 - add call-to-action empty states

[tazhibaevaaliya]

What are the changes introduced in this pull request?

Added call-to-actions for empty state on Host collections (under Host Overview Tab), Module Streams (under Content Tab), Repository sets, and Host content view selection (under Host Overview Tab -> Content View Details) pages/tabs

Considerations taken when implementing this change?

I believe that adding call-to-actions will increase user experience whenever they are no existing/available items/products/repos to show

What are the testing steps for this pull request?

For all the corresponding tabs:

1. Navigate to the corresponding tab/page
2. Assuming that you do not have available/existing items to show, you should see action button(s) (the number of action buttons depends on different number of the ways you can create a specific item/product/repo), which should direct you to the creation page
3. Try adding some items and searching for non-existing item. You should see a message indicating that such item does not exist without call-to-action button(s)

Note: there is a separate card created for the last action item (empty search)

[theforeman-bot]

Can one of the admins verify this patch?

[theforeman-bot]

Issues: #35012

[jeremylenz]

[test katello]

[tazhibaevaaliya]

Here are the screenshots of the final result on all four pages:

[jeremylenz]

Thanks @tazhibaevaaliya!

I'll let @lfu do the testing etc. but wanted to leave some code comments below.

Also, seems like the React tests will need some work!

[lfu]

Seems duplicated @jeremylenz's comments :)

Tests looked well for RHEL hosts.

But Debian hosts would get the same page for Repository sets and Module streams which seem not appropriate. Any thought? @jeremylenz

[jeremylenz]

But Debian hosts would get the same page for Repository sets and Module streams which seem not appropriate. Any thought?

Hmm.. We could maybe check if the deb content type is enabled and not show the RH Repos link if so? @ianballou would that even work? I would consider it extra credit either way.

[tazhibaevaaliya]

@jeremylenz @lfu What is the best way to incorporate your comments? Should I manually add and make another commit or there is an easier way?

[jeremylenz]

If you want to keep it squashed, you can make your changes and then

git add .
git commit --amend --no-edit

and force push.

If you want to add a commit instead, you can just add it and then do a regular push. I'm fine with either one 👍

[ianballou]

Hmm.. We could maybe check if the deb content type is enabled and not show the RH Repos link if so? @ianballou would that even work? I would consider it extra credit either way.

Debian is installed by default, so likely few upstream users would see this RH Repos link then.

Is there a fact or something that we could grab from the API to determine that the host is a RHEL one?

At least in Rails you can do ::Host.find(<id>).os which returns a Redhat object for my RHEL 7 host. Not sure if we expose that in the API.

Edit: on the content host page I see "OS" under "Content Host Properties", so there must be a way.

[jeremylenz]

Looks like the host details provides operatingsystem_name property:

operatingsystem_id: 4
operatingsystem_name: "RedHat 8.5"

We could see if that string contains "RedHat". Kinda hacky, but would save us another API request. thoughts?

[ianballou]

We could see if that string contains "RedHat". Kinda hacky, but would save us another API request. thoughts?

Here's the old logic for determining if a host is a Debian one: https://github.com/Katello/katello/blob/master/engines/bastion_katello/app/assets/javascripts/bastion_katello/hosts/host.factory.js#L30

[jeremylenz]

Love it 😆

[tazhibaevaaliya]

@ianballou @jeremylenz @lfu Will we need to create a separate card for this issue then?

[tazhibaevaaliya]

Also, quick question, once I committed, should I rebase once more to pick up the latest commit in my emptySearch/35027-add-link-to-clear-search branch? @jeremylenz

[jeremylenz]

should I rebase once more to pick up the latest commit in my emptySearch/35027-add-link-to-clear-search branch?

It's up to you. You'll have to fix any conflicts either way -- you're just choosing to do it later, when this PR is merged, or now if you decide to rebase. :)

[tazhibaevaaliya]

@jeremylenz Yay! I just love rebasing 😄

[lfu]

APJ

[jeremylenz]

[test katello]

[jeremylenz]

[test katello]

[lfu]

LGTM 👍🏻

[jeremylenz]

Great work @tazhibaevaaliya!

ACK 👍

[tazhibaevaaliya]

@jeremylenz and @lfu Thank you for all your help!