Fixes #35026 - As a user, I can edit ACS on the UI

[sjha4]

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

[theforeman-bot]

Issues: #35026

[ianballou]

Some comments about smart proxies and products with respect to organizations:

We'll need to remove the filtering on smart proxies and products since organization scope doesn't apply here.

Smart proxy names can still be used, but product names cannot because product names aren't unique across organizations.

[ianballou]

Also, it would be good to add a blurb telling folks that ACSs affect all repository syncs on any particular smart proxy.

[sjha4]

Some comments about smart proxies and products with respect to organizations:

We'll need to remove the filtering on smart proxies and products since organization scope doesn't apply here.

Smart proxy names can still be used, but product names cannot because product names aren't unique across organizations.

I will get the simplified ACS create and view PR in so we can get edits to work for both in this PR.

[sjha4]

Also, it would be good to add a blurb telling folks that ACSs affect all repository syncs on any particular smart proxy.

Ian, can you give this a test now and also where do you think this notice is appropriate? On the create wizard > Smart proxy screen + Review screen and the edit smart proxy modal?

To-do: Tests

[ianballou]

where do you think this notice is appropriate? On the create wizard > Smart proxy screen + Review screen and the edit smart proxy modal?

That sounds perfect to me!

[ianballou]

One thing I noticed was how the edit wizard handled errors. The error popped up in the background and the wizard stayed open. I tried adding a product to an yum ACS that had only a a file repo in it.

[ianballou]

I realized that clearing the upstream username and password isn't working. It seems we need something like this for ACS: https://github.com/Katello/katello/blob/master/app/models/katello/root_repository.rb#L263

[ianballou]

Everything is looking good to me now! Let me know when the last tests make it in.

[sjha4]

@ianballou : Added some more tests for simplified acs edits. Should be ready for re-review.