-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35026 - As a user, I can edit ACS on the UI #10184
Conversation
Issues: #35026 |
Some comments about smart proxies and products with respect to organizations: We'll need to remove the filtering on smart proxies and products since organization scope doesn't apply here. Smart proxy names can still be used, but product names cannot because product names aren't unique across organizations. |
Also, it would be good to add a blurb telling folks that ACSs affect all repository syncs on any particular smart proxy. |
I will get the simplified ACS create and view PR in so we can get edits to work for both in this PR. |
0b5d90c
to
2a343a1
Compare
2a343a1
to
1ad0768
Compare
1ad0768
to
0af7a25
Compare
Ian, can you give this a test now and also where do you think this notice is appropriate? On the create wizard > Smart proxy screen + Review screen and the edit smart proxy modal? To-do: Tests |
0af7a25
to
6bb7ce7
Compare
That sounds perfect to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed was how the edit wizard handled errors. The error popped up in the background and the wizard stayed open. I tried adding a product to an yum ACS that had only a a file repo in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that clearing the upstream username and password isn't working. It seems we need something like this for ACS: https://github.com/Katello/katello/blob/master/app/models/katello/root_repository.rb#L263
b00e9e6
to
24b0cbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is looking good to me now! Let me know when the last tests make it in.
24b0cbd
to
5e447de
Compare
@ianballou : Added some more tests for simplified acs edits. Should be ready for re-review. |
(cherry picked from commit b9299e3)
5e447de
to
bfc1189
Compare
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?