-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.5 GA Cherry Picks #10186
Merged
Merged
4.5 GA Cherry Picks #10186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #34872 - Search for errata tasks by scoped search * Fixes #34872 - Include errata by search * Fixes #34872 - Parse errata by search * Fixes #34872 - Store list of resolved errata IDs in the template * Fixes #34872 - Fix typo in the template * Fixes #34872 - Fix various edge cases - trim trailing newline - handle case when there are no erratas * Fixes #34872 - Bump rex dependency
Using labels to verify if a red hat repository already exists create issues when labels differ between exporting and importing servers. Keep the validation to use labels as fallback for custom products, which doesn't keep the same content id between importing and exporting server and for the case where the export didn't include content_id Co-authored-by: Joniel Pasqualetto <jpasqualetto@gmail.com>
Issues: #35119 |
ianballou
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me assuming the tests pass! We'll need to merge these next:
theforeman/foreman-packaging#8067
theforeman/foreman-packaging#8068
chris1984
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.