Fixes #35031 - Delete ModuleProfile and ModuleProfileRpms before ModuleStreams #10196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #35031 |
|
[test katello] |
sjha4
force-pushed
the
clean_duplicate_migration
branch
from
6808cb7
to
97c1998
Compare
sjha4
force-pushed
the
clean_duplicate_migration
branch
from
97c1998
to
b27f4b1
Compare
sjha4
force-pushed
the
clean_duplicate_migration
branch
from
b27f4b1
to
2456eca
Compare
sjha4
force-pushed
the
clean_duplicate_migration
branch
from
2456eca
to
cffc33c
Compare
|
Code looks good. starting to test |
chris1984
approved these changes
Jul 28, 2022
|
Works good, merge away |
ianballou
pushed a commit
to ianballou/katello
that referenced
this pull request
Sep 27, 2022
…leStreams (Katello#10196) (cherry picked from commit 6673240)
ianballou
pushed a commit
to ianballou/katello
that referenced
this pull request
Sep 27, 2022
…leStreams (Katello#10196) (cherry picked from commit 6673240)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Move deletion of child records before parent in migration.
Considerations taken when implementing this change?
I have a feeling destroy_all instead of delete_all for child records will resolve this too but it will be a costlier operation.
What are the testing steps for this pull request?