Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35238 - Remove sca toggle from manifest modal #10201

Merged
merged 1 commit into from Jul 25, 2022
Merged

Fixes #35238 - Remove sca toggle from manifest modal #10201

merged 1 commit into from Jul 25, 2022

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented Jul 18, 2022 •
edited

What are the changes introduced in this pull request?

  • With the start of the new candlepin upgrade feature work, toggling sca is no longer part of the manifest process, so this pr removes the toggle in the modal. You can still toggle it in the org settings

Considerations taken when implementing this change?

  • The test file I removed only tested the toggle of sca, so just removed it since it was not used by anything else.

What are the testing steps for this pull request?

  • Check out PR and verify there are no console errors on the subscription page or the manage manifest modal
  • Import a manifest/refresh/delete and check to make sure that all works correctly

@theforeman-bot
Copy link

Issues: #35238

@chris1984 chris1984 force-pushed the scamanifest branch 3 times, most recently from 7323476 to 9248d3c Compare July 20, 2022 14:35
lfu
lfu approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@lfu lfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@chris1984 chris1984 merged commit b306ac2 into Katello:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfu lfu lfu approved these changes

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@chris1984 @theforeman-bot @lfu