Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35276 - Add LCE controller to AngularJS so bookmarks work #10209

Merged
merged 1 commit into from Jul 27, 2022

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

In AngularJS we are missing the $scope.controllerName which allows bookmarks to be saved/created.

Considerations taken when implementing this change?

N/A

What are the testing steps for this pull request?

  • Apply PR
  • Try to create a bookmark under any of the tabs except details.
  • Verify it saved and we get a success response from the Foreman bookmarks controller.

@theforeman-bot
Copy link

Issues: #35276

Copy link
Member

@lfu lfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants