Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35313 - CV Version Compare - add other content types #10219

Conversation

tazhibaevaaliya
Copy link
Contributor

What are the changes introduced in this pull request?

Extended CV Version comparison feature to other content types, like Ansible collections and Python packages

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Publish two versions so that either of them has all the 9 content types (RPM Packages, RPM Package groups, Files, Docker tags, Debs, Errata, Module streams, Python packages and Ansible collections).
  2. Select those two versions in the list of all versions
  3. Hit "Compare" button
  4. Ensure that you are directed to the table with all 9 tabs for all the content types
  5. Try switching the tabs and ensure that all of the tabs render required information

@theforeman-bot
Copy link

Can one of the admins verify this patch?

@theforeman-bot
Copy link

Issues: #35313

@tazhibaevaaliya tazhibaevaaliya changed the title 35313 cv version compare add other content types Fixes #35313 - CV Version Compare - add other content types Aug 1, 2022
@jeremylenz
Copy link
Member

@tazhibaevaaliya Looks like this needs a rebase now that the other PR is merged..

@tazhibaevaaliya
Copy link
Contributor Author

@jeremylenz @sjha4 rebased it. Ready for the review 😅

@jeremylenz
Copy link
Member

@tazhibaevaaliya can you point me to the URLs I can sync to get all of the content types? 🙏

@tazhibaevaaliya
Copy link
Contributor Author

tazhibaevaaliya commented Aug 2, 2022

@jeremylenz Sure. Here is the list of repos I have:
repo1: https://jlsherrill.fedorapeople.org/fake-repos/needed-errata/
repo2: https://quay.io/
repo3: https://fixtures.pulpproject.org/debian/
repo4: https://fixtures.pulpproject.org/file/
repo5: https://galaxy.ansible.com/ AND requirements:

collections:

  • marmorag.ansodium

repo6: https://pypi.org AND includes: django~=2.0
repo7: https://partha.fedorapeople.org/test-repos/pteradactyl/

Hope this helps!

@tazhibaevaaliya tazhibaevaaliya force-pushed the 35313-cv-version-compare-add-other-content-types branch from aa3ae51 to 9277fa3 Compare August 2, 2022 21:40
@tazhibaevaaliya tazhibaevaaliya force-pushed the 35313-cv-version-compare-add-other-content-types branch from 9277fa3 to 19f7f3f Compare August 3, 2022 14:06
@sjha4
Copy link
Member

sjha4 commented Aug 3, 2022

[test katello]

@@ -169,6 +170,18 @@ export const getFilesComparison = (versionOne, versionTwo, params) => {
});
};

export const getContentComparison = (pluralLabel, versionOne, versionTwo, params) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const getContentComparison = (pluralLabel, versionOne, versionTwo, params) => {
export const getGenericContentComparison = (pluralLabel, versionOne, versionTwo, params) => {

Copy link
Member

@sjha4 sjha4 Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tazhibaevaaliya : Just add this to your other PR and we can merge this so you can stop worrying about rebasing and stuff..

@sjha4
Copy link
Member

sjha4 commented Aug 3, 2022

One small nitpick..Works well..Ready to go with one name change.

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tazhibaevaaliya ! Merging this. 🎉

@sjha4 sjha4 merged commit 6a96205 into Katello:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants