New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35313 - CV Version Compare - add other content types #10219
Fixes #35313 - CV Version Compare - add other content types #10219
Conversation
Can one of the admins verify this patch? |
Issues: #35313 |
@tazhibaevaaliya Looks like this needs a rebase now that the other PR is merged.. |
d3d73c0
to
4d5720e
Compare
4d5720e
to
aa3ae51
Compare
@jeremylenz @sjha4 rebased it. Ready for the review 😅 |
@tazhibaevaaliya can you point me to the URLs I can sync to get all of the content types? 🙏 |
@jeremylenz Sure. Here is the list of repos I have:
|
aa3ae51
to
9277fa3
Compare
webpack/scenes/ContentViews/Details/ContentViewDetailActions.js
Outdated
Show resolved
Hide resolved
9277fa3
to
19f7f3f
Compare
[test katello] |
@@ -169,6 +170,18 @@ export const getFilesComparison = (versionOne, versionTwo, params) => { | |||
}); | |||
}; | |||
|
|||
export const getContentComparison = (pluralLabel, versionOne, versionTwo, params) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const getContentComparison = (pluralLabel, versionOne, versionTwo, params) => { | |
export const getGenericContentComparison = (pluralLabel, versionOne, versionTwo, params) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tazhibaevaaliya : Just add this to your other PR and we can merge this so you can stop worrying about rebasing and stuff..
webpack/scenes/ContentViews/Details/Versions/Compare/__tests__/CVVersionCompare.test.js
Show resolved
Hide resolved
One small nitpick..Works well..Ready to go with one name change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @tazhibaevaaliya ! Merging this. 🎉
What are the changes introduced in this pull request?
Extended CV Version comparison feature to other content types, like Ansible collections and Python packages
Considerations taken when implementing this change?
What are the testing steps for this pull request?