Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35737 - Filter by id includes module streams of other arch #10343

Merged
merged 1 commit into from Nov 17, 2022

Conversation

hao-yu
Copy link
Contributor

@hao-yu hao-yu commented Nov 9, 2022

The issue is not completely fix in PR #10308. It is still reproducible when filtering errata by ids.

This PR is to fix the remaining issue.

@theforeman-bot
Copy link

Issues: #35737

Content view filter by errata id includes module streams of
multiple arches not in the source repository.
@hao-yu hao-yu force-pushed the fix_35737_filter_errata_by_id branch from 0cb9995 to d02a79d Compare November 9, 2022 03:06
@ianballou
Copy link
Member

Just making sure I understand -- the issue is that an erratum can be shared between repositories with different architectures? So an erratum's module streams in Katello will return streams of varying architectures, and thus the fix is to narrow down the search to only module streams in the source repository.

@hao-yu
Copy link
Contributor Author

hao-yu commented Nov 11, 2022

@ianballou correct!

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me!

@ianballou ianballou merged commit 279073d into Katello:master Nov 17, 2022
chris1984 pushed a commit to chris1984/katello that referenced this pull request Nov 28, 2022
…tello#10343)

Content view filter by errata id includes module streams of
multiple arches not in the source repository.

(cherry picked from commit 279073d)
chris1984 pushed a commit that referenced this pull request Nov 28, 2022
…0343)

Content view filter by errata id includes module streams of
multiple arches not in the source repository.

(cherry picked from commit 279073d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants