Fixes #35878 - CV and LCE name show empty strings in RepoSets banner #10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
When you set the toggle to 'Limit to environment', the Repository Sets tab has a banner
However, since the multi-CV work it has said
This is because Rails no longer provides the methods
content_view_nameandlifecycle_environment_nameon content facets.This fixes that.
Considerations taken when implementing this change?
When we start updating the UI for multi-CV, we'll have to change this text again. But I didn't want to do that prematurely.
What are the testing steps for this pull request?
put a host in a non-library CV/LCE
view the Repo Sets tab