Refs #35236 - ak update requires the existence of organization #10414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
reviewed
Jan 16, 2023
There was a problem hiding this comment.
Works well!
Before:
$ hammer activation-key update --name=dev --organization-id=1 --release-version=8
Could not update the activation key:
undefined method `library' for nil:NilClass
After:
$ hammer activation-key update --name=dev --organization-id=1 --release-version=8
Activation key updated.
$ hammer activation-key update --name=dev --organization-id=1 --release-version="hoo"
Could not update the activation key:
Invalid release version: [hoo]
I'd also like to see a test added that reflects this change.
lfu
changed the title
lfu
force-pushed
the
update_invalid_release_version_35236
branch
from
c78b630
to
ac6cf9a
Compare
lfu
force-pushed
the
update_invalid_release_version_35236
branch
from
ac6cf9a
to
cf4f033
Compare
jeremylenz
reviewed
Jan 17, 2023
Comment on lines
299
to
302
| activation_key = ActivationKey.new( | ||
| :name => 'new key', :organization => @organization | ||
| ) | ||
| assert activation_key.save |
There was a problem hiding this comment.
We're not testing the model's validity here, so I'd say the assert .. save isn't needed. (It's probably not needed in the previous test either.) I'd just go with ActivationKey.create!
lfu
force-pushed
the
update_invalid_release_version_35236
branch
from
cf4f033
to
219a307
Compare
jeremylenz
approved these changes
Jan 19, 2023
lfu
force-pushed
the
update_invalid_release_version_35236
branch
from
219a307
to
b25b238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Make sure
organizationexists to avoid an error like:Considerations taken when implementing this change?
Followup of #10200
What are the testing steps for this pull request?
hammer activation-key update --name=test5 --organization-id=1 --release-version='willthiswork'
Before
After