Fixes #35947 - Consume install_all param when finding hosts

[jeremylenz]

What are the changes introduced in this pull request?

When selecting all hosts on the Errata page, Bastion was sending an install_all param but the backend was ignoring it. This resulted in an error "No hosts have been specified."

In addition, after fixing that I discovered that Bastion was only sending the ids param and not the search param, resulting in the "all hosts" selection meaning "ALL hosts, not just those with this errata applicable." That should be fixed now too.

Considerations taken when implementing this change?

The bulk errata controller seems to be the only Angular page that sends the install_all param. The name is a bit misleading because it's sent when selecting hosts, not errata.

What are the testing steps for this pull request?

1. Content > Errata
2. Select any errata with 1 or more installable hosts, and click Apply Errata
3. On the host list page, Click the checkbox above "Name" to select the page of results
4. (Important) A banner appears with a link to "Select all xxx" - Click this to activate select all. The banner will turn green and say "X results are selected."
5. Click Next and then Confirm

Before this patch: You'd get an error that no hosts have been specified.
After this patch: You'll be taken to the remote execution job.

[ianballou]

I'm not reproducing the issue because, with this particular workflow, Katello keeps using katello-agent even though I selected to use remote execution by default. What else did you do to get it to use remote execution?

I'm assuming that the issue only occurs when remote execution is in use. I'm not reproducing the error with katello-agent.

[jeremylenz]

What else did you do to get it to use remote execution?

You shouldn't have to, but you could try disabling katello-agent via the installer with --foreman-proxy-content-enable-katello-agent=false

[ianballou]

I found a general issue with this workflow -- install_all will try installing errata on hosts that do not have that errata marked as applicable. To reproduce the issue, try having two hosts, but only one has an erratum that is applicable. The remote execution job will be run for both hosts instead of just the one applicable host.

[jeremylenz]

install_all will try installing errata on hosts that do not have that errata marked as applicable. To reproduce the issue, try having two hosts, but only one has an erratum that is applicable. The remote execution job will be run for both hosts instead of just the one applicable host.

Finally got this set up, but I'm not seeing the issue. My REX job is scoped correctly to name ^ (rhel8b.fedora.example.com)..

[ianballou]

@jeremylenz do you have a host that has no content facet? I have one host with a content facet and one without, that's the only difference I could potentially see with my setup ...

[ianballou]

You can see the centos8-proxy-devel host on the bottom that has no content facet, which makes it even more confusing why errata is trying to be applied to it.

[ianballou]

So strange, it really is applying it to all of my hosts.

[ianballou]

find_bulk_hosts at least is returning my one requested host.

Edit: it looks like this method is being called multiple times, and one of the calls is wrong somehow.

[ianballou]

In the remote execution controller in Katello, my bulk_host_params looks like this: {:included=>{:ids=>[]}}

In my params I see this: "install_all"=>""

It really doesn't make sense, but it seems the install_all param is failing to be passed along from the UI.

[ianballou]

I reproduced the issue I found on a separate Katello development environment that is also on a different computer. I'm using Firefox (but I saw the same in Chrome).

Screencast.from.02-06-2023.05.28.56.PM.webm

[ianballou]

From debugging:

[8] pry(#<Katello::Api::V2::HostsBulkActionsController>)> params[:install_all]
22:39:47 rails.1   | => nil

[9] pry(#<Katello::Api::V2::HostsBulkActionsController>)> bulk_params[:included][:ids]
22:40:02 rails.1   | => []

[10] pry(#<Katello::Api::V2::HostsBulkActionsController>)> bulk_params[:included][:search]
22:40:17 rails.1   | => "( applicable_errata = \"RHEA-2012:0055\" )"

[ianballou]

What's weird is, I don't have install_all, but I do see a param called just "all":

=> #<ActionController::Parameters {"included"=>#<ActionController::Parameters {"ids"=>[], "resources"=>[], "search"=>"( applicable_errata = \"RHEA-2012:0055\" )", "params"=>{"organization_id"=>"1", "paged"=>true, "page"=>1, "per_page"=>"20", "search"=>"( applicable_errata = \"RHEA-2012:0055\" )"}} permitted: false>, "excluded"=>#<ActionController::Parameters {"ids"=>[]} permitted: false>, "all"=>true, "errata_ids"=>["RHEA-2012:0055"], "organization_id"=>"1", "api_version"=>"v2", "controller"=>"katello/api/v2/hosts_bulk_actions", "action"=>"available_incremental_updates", "hosts_bulk_action"=>{"included"=>{"ids"=>[], "resources"=>[], "search"=>"( applicable_errata = \"RHEA-2012:0055\" )", "params"=>{"organization_id"=>"1", "paged"=>true, "page"=>1, "per_page"=>"20", "search"=>"( applicable_errata = \"RHEA-2012:0055\" )"}}, "excluded"=>{"ids"=>[]}, "all"=>true, "errata_ids"=>["RHEA-2012:0055"], "organization_id"=>"1"}} permitted: false>

This :all could be related to this: https://github.com/Katello/katello/blob/master/app/controllers/katello/concerns/api/v2/bulk_extensions.rb#L14

Edit: In my debugging, when I don't have install_all, I do always have all being either true or false in the correct manner.

[jeremylenz]

Hmm.. 🤔

Does a manual host search for "( applicable_errata = \"RHEA-2012:0055\" )" return the expected hosts, or all hosts?

[ianballou]

Hmm.. thinking

Does a manual host search for "( applicable_errata = \"RHEA-2012:0055\" )" return the expected hosts, or all hosts?

That returns only the correct host.

[jeremylenz]

@ianballou Updated; give it another whirl ♻️

[ianballou]

Looks good to me! I tested with page size of 1 so we know that it works across pages. I also tested some of the bulk errata workflows to ensure nothing there was broken.

[ianballou]

Looks like an angular test is failing