-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35961 - Simple Content Access API shouldn't check upstream connection #10422
Conversation
Issues: #35961 |
2734a07
to
3d6e03e
Compare
3d6e03e
to
c6965ef
Compare
Fixed tests, ready for review ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks sane, left one comment. Will start to test
c6965ef
to
a5d1c4a
Compare
@chris1984 Added deprecation warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, works great. Thanks for adding the dep warning @jeremylenz
What are the changes introduced in this pull request?
The
organizations/:id/simple_content_access/
API endpoints were never updated after the upgrade to Candlepin 4.2. This means thatThis change reflects that SCA is now tied to the organization, and no longer requires a connection to the upstream Candlepin consumer.
Considerations taken when implementing this change?
I'm not entirely sure if the
/eligible
endpoint is necessary any more. But I left it in for backward compatibility.What are the testing steps for this pull request?
Get an organization with no manifest imported
Before:
After:
API responses as expected