Refs #35873 - More ouia-ids for ACS #10423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #35873 |
chris1984
reviewed
Jan 19, 2023
| @@ -16,7 +16,7 @@ global.console.error = (error, stack) => { | |||
| // 'The prop `ouiaId` is marked as required in `Modal`, but its value is `undefined`', | |||
| // 'created by WizardHeader', 'created by Navigation', | |||
| // 'created by ActionsColumn', 'created by InactiveText', 'created by Select', | |||
| // 'created by Context.Consumer']; | |||
| // 'created by Context.Consumer', 'created by DualListSelector']; | |||
There was a problem hiding this comment.
It's this patternfly component: https://www.patternfly.org/v4/components/dual-list-selector/
We use it on ACS creation wizard to select products and smart proxies. The component internally renders some child components which are ouia-id enabled but we can't set those in our code directly. Hence ignoring those for now.
chris1984
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Add ouiaId prop to supported PF4 components in ACS UI.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Uncomment
webpack/global_test_setup.jsas desiredRun
npx jest webpack/scenes/AlternateContentSources/See if any components complain about ouia-ids.