Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35965 - properly clean orphaned smart proxy remotes #10425

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Properly causes orphaned remotes to be deleted from smart proxies during orphan cleanup. Before, the filtering included all repositories that are in the database. Now, it only considers repositories that are available to the smart proxy.

Considerations taken when implementing this change?

None worth mentioning.

What are the testing steps for this pull request?

  1. Register a smart proxy and create a new pulp-cli profile.
  2. Look at the remotes on the smart proxy.
pulp --profile proxy rpm remote list
  1. Sync a smart proxy to some environment.
  2. Look at the created remotes.
  3. Remove all (or some) environments from the smart proxy
  4. Run orphan cleanup: katello:delete_orphaned_content
  5. Check the remotes again. The remotes associated to the now-removed environments should be gone.
  6. Try the process again after re-adding the environments.

@theforeman-bot
Copy link

Issues: #35965

@ianballou ianballou force-pushed the 35965-delete-orphan-remotes-smart-proxy-issue branch from 8042897 to 0f007af Compare January 25, 2023 15:33
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 👍🏼

@ianballou ianballou merged commit 9e6cab2 into Katello:master Jan 28, 2023
@ianballou ianballou deleted the 35965-delete-orphan-remotes-smart-proxy-issue branch January 28, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants