Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36103 - Address Paginaion issue on ACS Main Table #10452

Merged
merged 1 commit into from Feb 15, 2023

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Feb 15, 2023

What are the changes introduced in this pull request?

ACS Main page was not showing the correct behavior on Select Page/Select None.
This was because the selectedCount was not getting passed.

What are the testing steps for this pull request?

  • Setup a bunch of ACS' more than the page size. I used following hammer script
for i in  {1..25}
do 
hammer alternate-content-source create --alternate-content-source-type custom --name "$RANDOM - test" --content-type yum --base-url https://potato.com/ --smart-proxy-ids 1
 done
  • Now go to Content -> Alternate Content Sources
  • Do a select page (via checkbox)
  • Try unselecting

Before PR
Cannot Unselect

After PR
Unselection and other pagination aspects all work.

@theforeman-bot
Copy link

Issues: #36103

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before change: Disabled select none option:
Screenshot from 2023-02-15 18-31-42

After PR: Enabled select none option:
Screenshot from 2023-02-15 18-34-11

Ack 👍🏼

@parthaa parthaa merged commit 8cb8f27 into Katello:master Feb 15, 2023
qcjames53 pushed a commit to qcjames53/katello that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants