New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35559 - Change Content Source LCE dropdown should not show multiple Library entries #10457
Fixes #35559 - Change Content Source LCE dropdown should not show multiple Library entries #10457
Conversation
Issues: #35559 |
@lfu I thought we were going to move to the new CV/LCE selector? (See the Redmine issue) |
1b96e37
to
b899cb2
Compare
b899cb2
to
fee876a
Compare
@jeremylenz do you want me to review this so you can focus on other things? |
@chris1984 feel free to review as you like! But I definitely want to see the results of this, since it will become even more important once the multi-CV work starts up again :) |
fee876a
to
42b6645
Compare
Updated. |
42b6645
to
ad1c1bd
Compare
ad1c1bd
to
191f2b8
Compare
…tiple Library entries
191f2b8
to
826d656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already fixed the bug - confirmed that the environment paths (including Library) are only shown for the current organization context.
This is looking fine once the code is cleaned up; see below :)
webpack/scenes/ContentViews/components/ContentViewSelect/ContentViewSelectOption.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better!!
webpack/components/extensions/HostDetails/Cards/ContentViewDetailsCard/ChangeHostCVModal.js
Outdated
Show resolved
Hide resolved
037e299
to
5a4e1d4
Compare
5a4e1d4
to
9677b2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks better now, thanks :)
Couple more things:
- After the update process is complete, I am able to re-select a different content source and env/CV, even though the Update button remains disabled. Can we just disable everything after the update is complete?
- If no content views are available for the selected environment, can we add the banner like we have in the ChangeHostCVModal?
9677b2f
to
67d5191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the changes introduced in this pull request?
There should be only one 'Library' selection in the dropdown. Which Library it is depends on the organization selector.
Considerations taken when implementing this change?
What are the testing steps for this pull request?