Fixes #36269 - Add check_needs_publish param and logic to publish API #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36269 |
parthaa
reviewed
Apr 18, 2023
| @@ -109,23 +109,14 @@ def update | |||
| param :major, :number, :desc => N_("Override the major version number"), :required => false | |||
| param :minor, :number, :desc => N_("Override the minor version number"), :required => false | |||
| param :environment_ids, Array, :desc => N_("Identifiers for Lifecycle Environment"), :required => false | |||
| param :is_force_promote, :bool, :desc => N_("force content view promotion and bypass lifecycle environment restriction"), :required => false | |||
| param :check_needs_publish, :bool, :desc => N_("Check if content view needs a publish even based on audited changes since last publish"), :required => false | |||
There was a problem hiding this comment.
Suggested change
| param :check_needs_publish, :bool, :desc => N_("Check if content view needs a publish even based on audited changes since last publish"), :required => false | |
| param :publish_if_needed, :bool, :desc => N_("Check if content view needs a publish even based on audited changes since last publish"), :required => false |
I dont know if this sounds better. @jeremylenz what da ya think
There was a problem hiding this comment.
Yeah, I'd go even farther
Suggested change
| param :check_needs_publish, :bool, :desc => N_("Check if content view needs a publish even based on audited changes since last publish"), :required => false | |
| param :publish_only_if_needed, :bool, :desc => N_("Check audited changes and proceed only if content or filters have changed since last publish"), :required => false |
parthaa
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds a
check_needs_publishparameter to the content view publish API (That defaults to false) and determine if publish is needed on CV and don't publish if not needed.Considerations taken when implementing this change?
The needs_publish method is currently implemented for repository change auditing. There's a PR out for factoring in filter + filter rules changes and this PR should work out of the box when merged.
What are the testing steps for this pull request?
hammer content-view publish --id 2 --check-needs-publish truehammer content-view publish --id 2 --check-needs-publish falseorIn hammer, runhammer content-view publish --id 2`