Fixes #36390 - Orphan cleanup on capsules #10554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36390 |
|
[test katello] |
ianballou
reviewed
May 19, 2023
There was a problem hiding this comment.
Should we address this comment too? https://bugzilla.redhat.com/show_bug.cgi?id=2043089#c5
"I would also update the description of the parameter from " Time in minutes to consider orphan content as orphaned." to "Time in minutes before content not contained within a repo nor recently touched will be considered as orphaned"
The existing description doesn't really capture what is going on."
ianballou
reviewed
May 19, 2023
ianballou
approved these changes
May 30, 2023
wbclark
pushed a commit
to wbclark/katello
that referenced
this pull request
Jun 6, 2023
(cherry picked from commit 0c6298a)
wbclark
pushed a commit
that referenced
this pull request
Jun 6, 2023
(cherry picked from commit 0c6298a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Run pulp orphan cleanup after removing other records like unneeded repositories etc which create orphaned content of their own.
Run capsule orphan cleanup with orphan_protection_time as 0.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Set up a capsule assigned to Default organization that also has some repo content (Synced with immediate download policy)
Sync.
Notice files in /var/lib/pulp/media/artifact//
Remove Default Organization from the capsule and run
bundle exec rails katello:delete_orphaned_contentNotice files in /var/lib/pulp/media/artifact// . It should be empty since all the downloaded content is orphaned.