Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36420 - Correct aria-label for description #10565

Merged
merged 1 commit into from
May 25, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented May 19, 2023

What are the changes introduced in this pull request?

Correct aria-label of description field value on ACS details.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Go to ACS details page.
  2. Inspect description value in the details.
  3. Check if aria-label changed to description_text_value

@theforeman-bot
Copy link

Issues: #36420

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I can see the change in the screenshot below
ouia

@sjha4 sjha4 merged commit b02da00 into Katello:master May 25, 2023
5 checks passed
ianballou pushed a commit to ianballou/katello that referenced this pull request May 26, 2023
ianballou pushed a commit that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants