Fixes #36425 - request backend status with a trailing slash #10568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36425 |
ekohl
approved these changes
May 23, 2023
There was a problem hiding this comment.
I noticed this too and mentioned it to @ianballou (I think on IRC). Simple fix, but does indeed save resources.
|
another optimization could be to reduce the number of requests, right now there are two (one for |
|
[test katello] |
|
heh, I guess there is some more mocking/vcring to do :> |
Candlepin doesn't mind either way, but Pulp really wants that slash, which results in a redirect if we request the non-slashed URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Candlepin doesn't mind either way, but Pulp really wants that slash, which results in a redirect if we request the non-slashed URL.
So this PR changes the status URL to end with a
/Considerations taken when implementing this change?
None.
What are the testing steps for this pull request?
Ensure
Katello::Pingstill works with Candlepin and Pulp, e.g. by callinghammer ping