Fixes #36428 - Don't trigger pulp tasks on ignorable_content updates #10578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36428 |
ianballou
reviewed
Jun 8, 2023
| @@ -407,7 +407,7 @@ def on_demand? | |||
|
|
|||
| def pulp_update_needed? | |||
| changeable_attributes = %w(url unprotected checksum_type docker_upstream_name download_policy mirroring_policy verify_ssl_on_sync | |||
There was a problem hiding this comment.
We don't need mirroring_policy either since it's passed in at sync time too:
Suggested change
| changeable_attributes = %w(url unprotected checksum_type docker_upstream_name download_policy mirroring_policy verify_ssl_on_sync | |
| changeable_attributes = %w(url unprotected checksum_type docker_upstream_name download_policy verify_ssl_on_sync |
There was a problem hiding this comment.
Added mirroring policy.. 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Ignorable_content is a param on pulp repository sync API and isn't stored anywhere other than katello. An update to ignorable_content shouldn't trigger unnecessary pulp tasks since we don't actually update anything in pulp. A sync will perform all the required steps to ignore updated list.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Ex srpm repo to test srpm is ignored in the next sync: https://fixtures.pulpproject.org/srpm-unsigned/
Ex treeinfo repo to test ignore treeinfo: https://www.keepersecurity.com/kcm/2/el/8/x86_64 (Note: sync will fail without ignoring treeinfo)
Make sure your repo isn't doing an additive sync cause that will not delete srpms that have been synced on repo before.