-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36500 - Optimize DockerMetaTag query and CV version deletion to run a single invocation of the method #10599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: #36500 |
[test katello] |
Test failure related. Will update. |
sjha4
force-pushed
the
docker_metatag_cleanup
branch
from
June 14, 2023 20:37
c6a98e7
to
96681a0
Compare
sjha4
force-pushed
the
docker_metatag_cleanup
branch
from
June 15, 2023 14:31
96681a0
to
79b8f14
Compare
parthaa
reviewed
Jul 18, 2023
parthaa
reviewed
Jul 18, 2023
parthaa
reviewed
Jul 18, 2023
parthaa
reviewed
Jul 18, 2023
parthaa
reviewed
Jul 18, 2023
Other than cleanup the code looks ok. I am going to quickly test once the suggested changes have been addressed. |
sjha4
force-pushed
the
docker_metatag_cleanup
branch
from
July 19, 2023 17:09
79b8f14
to
3afa750
Compare
sjha4
force-pushed
the
docker_metatag_cleanup
branch
from
July 19, 2023 17:13
3afa750
to
cfbb2ea
Compare
…o run a single invocation of the method
sjha4
force-pushed
the
docker_metatag_cleanup
branch
from
July 20, 2023 00:29
cfbb2ea
to
5a60c86
Compare
parthaa
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised :)
wbclark
pushed a commit
to wbclark/katello
that referenced
this pull request
Sep 7, 2023
…o run a single invocation of the method (Katello#10599) (cherry picked from commit 6077a1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Once for removing CV from environment and once for deleting CV version itself
Considerations taken when implementing this change?
What are the testing steps for this pull request?