Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36510 - Update aria-label and ouia-id on edit credential modal #10610

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Jun 15, 2023

What are the changes introduced in this pull request?

Update aria-label and ouia-id of submit/cancel buttons as recommended.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Go to ACS details > Edit credential > Inspect Submit and Cancel buttons and make sure ouia-id and aria-labels are updated as requested by automation.

@theforeman-bot
Copy link

Issues: #36510

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ouiaId is now correct.

@sjha4
Copy link
Member Author

sjha4 commented Jun 15, 2023

[test katello]

@sjha4 sjha4 merged commit bb874ab into Katello:master Jun 15, 2023
5 checks passed
@sjha4 sjha4 deleted the issue#36510 branch June 15, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants