Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36504 - Use assign_single_environment in bulk action #10615

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

jeremylenz
Copy link
Member

@jeremylenz jeremylenz commented Jun 16, 2023

What are the changes introduced in this pull request?

The Content host bulk action "Change Lifecycle Environment" was still trying to do .content_view = and .lifecycle_environment = . These methods no longer exist. This updates the code to use assign_single_environment.

Considerations taken when implementing this change?

wow that bulk action UI is baaaad...

What are the testing steps for this pull request?

Hosts > Content Hosts > Select one or more content hosts > Actions > Change Lifecycle Environment
Pick an environment and content view
Click Submit and then Yes (not Done lol)

Before: Task will pause with warning; Dynflow subplan will show error undefined method content_view=' for #Katello::Host::ContentFacet`

After: Task completes successfully.

@theforeman-bot
Copy link

Issues: #36504

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before PR:
Screenshot from 2023-06-16 10-20-32
After PR:
Screenshot from 2023-06-16 10-24-33

Code looks good and works as advertised. APJ 👍🏼

@jeremylenz jeremylenz merged commit ccd234a into Katello:master Jun 16, 2023
5 checks passed
lfu pushed a commit to lfu/katello that referenced this pull request Jun 21, 2023
lfu pushed a commit that referenced this pull request Jun 21, 2023
wbclark pushed a commit to wbclark/katello that referenced this pull request Sep 7, 2023
wbclark pushed a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants