Fixes #36515 - Don't show promote out of order for in-order envs #10617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36515 |
sjha4
force-pushed
the
cv_promote_publish_warning
branch
from
8685eb3
to
aade35a
Compare
sjha4
force-pushed
the
cv_promote_publish_warning
branch
from
aade35a
to
1d43c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
If the env to be promoted to has prior env checked or already promoted to, even if the prior promoted env is out of order, don't show out of order warning
Considerations taken when implementing this change?
Scenarios in issue
What are the testing steps for this pull request?
Consider a promotion like this:
Env qa is now considered 'in-order' because version is already published to previous env test (which was out of order, notice missing env dev). We don't have to consider test being out of order anymore. As a result qa is in-order. If you uncheck qa, check prod, prod is still out of order. Hope that makes sense.. :)