Fixes #36288 - Wrong listing of Content Views which contain Files #10622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36288 |
ianballou
reviewed
Jul 19, 2023
I will update the table. We are returning versions and trying to map them to CV names without versions I think in the tab. |
|
Ended up being a small change. Old code was linking to old CV UI.. 💀 😅 |
ianballou
reviewed
Jul 21, 2023
...n_katello/app/assets/javascripts/bastion_katello/files/details/views/file-content-views.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Add file_id as a param to cv version API as bastion expects the API call to accept the parameter
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Before PR:
Views shows all CV versions in the system. No file filter applied.
After PR:
Only CV versions that contain file unit are shown.