Fixes #36221 - Allow removing products with empty URL repos from ACS #10625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36221 |
sjha4
changed the title
qcjames53
approved these changes
Jul 5, 2023
jeremylenz
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Check for presence of ACSSmartProxy before planning delete task
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Create a product.
Create a yum repository with URL, sync and everything you'd do normally.
Create another yum repo without a URL.
Create a simplified ACS and add the product to it.
Try removing that product from the ACS. It fails without this PR cause we don't create SmartProxyACS records for empty URL repos.