Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36529 - CV page needs refresh to get the current filters state #10628

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Jun 23, 2023

What are the changes introduced in this pull request?

  1. Reload cv filters on publish screen when wizard is opened to get accurate state of filters on the CV.
  2. Needs_publish is now reset if you move from one CV to another.

What are the testing steps for this pull request?

  1. Go to a CV without filters.
  2. Go to filters tab. Create a new filter.
  3. Hit Publish new version button and go to Review step. You should see the notice that filters will be applied.
  4. Publish.
  5. Go back to filters tab. Delete the single filter and hit publish.
  6. You should not see the warning now.

Small bug fix with needs_publish UI:
Have 2 CVs with some published versions in the box. Make sure none need publish at the moment. (Aka no needs_publish icon on the version)

  1. Go to a CV and create a new filter.
  2. Go to versions tab and see that needs_publish icon is shown.
  3. Go to another CV and make sure the needs_publish icon is not shown.

@theforeman-bot
Copy link

Issues: #36529

Copy link
Contributor

@qcjames53 qcjames53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Samir!

I was able to confirm the two new features through testing. I threw a couple different scenarios at the CVs to see if I could break anything but everything held up :)

The source looks good to me. I'm giving this a solid stamp of approval.

@sjha4 sjha4 merged commit 009f5c6 into Katello:master Jul 6, 2023
5 checks passed
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 20, 2023
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 21, 2023
wbclark pushed a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants