Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36584 - Update realtive_path to text in the db from char #10642

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • In Pulp the core_distribution table and column base_path is text without a limit so this PR removes the limit from our DB to match pulp
  • This was the approach I worked with Ian on and he said go for it.

Considerations taken when implementing this change?

  • I tested with a rhel7 and centos8-stream box and was able to pull content fine, pulp/candlepin were working fine

What are the testing steps for this pull request?

  • Create a product with long label name (For example: Community_Extra_Packages_for_Enterprise_Linux_EPEL_debug)
  • Create a repository with long label name (Fore example: Community_Extra_Packages_for_Enterprise_Linux_EPEL_8_Modular_x86_64_debug)
  • Sync the repository
  • Create a content view with label along Community_Extra_Packages_for_Enterprise_Linux_EPEL_8_Modular_x86_64_debug_100000
  • Publish

Without PR you should get Error => "Validation failed: Relative path is too long (maximum is 255 characters)"

@theforeman-bot
Copy link

Issues: #36584

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as per instructions and worked for me!

image

ACK 👍 thanks @chris1984!

@jeremylenz
Copy link
Member

test failures unrelated

@chris1984
Copy link
Member Author

[test katello]

@sjha4
Copy link
Member

sjha4 commented Jul 14, 2023

💚 💚

@chris1984 chris1984 merged commit 776036f into Katello:master Jul 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants