Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36586 - pin ostree bindings below 2.1.1 #10645

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Pins the ostree client version to before 2.1.0.

As of 2.1.0, there is a new hidden distribution attribute that is breaking the VCRs.

Considerations taken when implementing this change?

Re-recording the VCRs to fix this would be incorrect because Katello's packaged version of pulp ostree likely does not support the hidden distribution feature.

What are the testing steps for this pull request?

See the tests pass.

@theforeman-bot
Copy link

Issues: #36586

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ 👍

@sjha4
Copy link
Member

sjha4 commented Jul 12, 2023

So this http://koji.katello.org/releases/yum/katello-nightly/katello/el8/x86_64/rubygem-pulp_ostree_client-2.1.0-1.el8.noarch.rpm says 2.1.0 is packaged for nightly..Not sure if that conflicts with < 2.1.0

@ianballou
Copy link
Member Author

So this http://koji.katello.org/releases/yum/katello-nightly/katello/el8/x86_64/rubygem-pulp_ostree_client-2.1.0-1.el8.noarch.rpm says 2.1.0 is packaged for nightly..Not sure if that conflicts with < 2.1.0

@sjha4 we shouldn't be packaging that version of the ostree client yet, I'll have to ask to have it pulled out (or at least make sure we still have the older versions).

@ianballou
Copy link
Member Author

Updated the pinning.

@ianballou ianballou changed the title Fixes #36586 - pin ostree bindings below 2.1.0 Fixes #36586 - pin ostree bindings below 2.1.1 Jul 13, 2023
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@chris1984
Copy link
Member

🟢

@ianballou ianballou merged commit ba8eb2a into Katello:master Jul 13, 2023
5 checks passed
@ianballou ianballou deleted the 36586-ostree-pin branch July 13, 2023 15:07
parthaa pushed a commit to parthaa/katello that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants