-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36586 - pin ostree bindings below 2.1.1 #10645
Conversation
Issues: #36586 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APJ 👍
So this http://koji.katello.org/releases/yum/katello-nightly/katello/el8/x86_64/rubygem-pulp_ostree_client-2.1.0-1.el8.noarch.rpm says 2.1.0 is packaged for nightly..Not sure if that conflicts with < 2.1.0 |
@sjha4 we shouldn't be packaging that version of the ostree client yet, I'll have to ask to have it pulled out (or at least make sure we still have the older versions). |
432f020
to
3eb30d5
Compare
Updated the pinning. |
3eb30d5
to
5521672
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
🟢 |
What are the changes introduced in this pull request?
Pins the ostree client version to before 2.1.0.
As of 2.1.0, there is a new hidden distribution attribute that is breaking the VCRs.
Considerations taken when implementing this change?
Re-recording the VCRs to fix this would be incorrect because Katello's packaged version of pulp ostree likely does not support the hidden distribution feature.
What are the testing steps for this pull request?
See the tests pass.