Fixes #36589 - Added ability to refresh all alternate content sources… #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcjames53
force-pushed
the
36589-add-acs-refresh-all
branch
from
483e8d3
to
c050e48
Compare
sjha4
reviewed
Jul 14, 2023
app/controllers/katello/api/v2/alternate_content_sources_bulk_actions_controller.rb
Outdated
Show resolved
Hide resolved
… using API POST call at /alternate_content_sources/bulk/refresh_all Fixes #36589 - Added ability to refresh all alternate content sources using API POST call at /alternate_content_sources/bulk/refresh_all Fixed broken permissions. Added suggested change from Samir
qcjames53
force-pushed
the
36589-add-acs-refresh-all
branch
from
c050e48
to
6a7f020
Compare
|
Code looks good..Will do some testing.. 👍🏼 |
sjha4
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Works great. Tested with hammer PR: Katello/hammer-cli-katello#902 and both worked as advertised. Ack. Please merge after @ofedoren acks the hammer PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… using API POST call at /alternate_content_sources/bulk/refresh_all
What are the changes introduced in this pull request?
Sending a POST request to
http://centos8-katello-devel.redhat.example.com/katello/api/alternate_content_sources/bulk/refresh_allwill refresh all alternate content sources. This is the first half of the implementation of #36589 (adding refresh all support to hammer); the remaining changes will need to be made on hammer's end to support bulk actions.Considerations taken when implementing this change?
n/a
What are the testing steps for this pull request?
Create a Katello instance with no alternate content sources. Run the following command to request to refresh all ACS's:
Since there are no ACS's, the command should fail:
Now add a few alternate content sources and monitor the last refreshed time (I used the web UI). Run the same command as before:
The alternate content sources should all have been refreshed.