Fixes #36590 - fix ACS error message for duplicate words #10647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36590 |
lfu
force-pushed
the
acs_errors_product_msg_36590
branch
from
efb81f9
to
74aea7a
Compare
lfu
commented
Jul 13, 2023
| @@ -7,7 +7,7 @@ def validate_each(record, attribute, value) | |||
| product = ::Katello::Product.find(value) | |||
| content_type = record.alternate_content_source.content_type | |||
| if product.repositories.with_type(content_type).has_url.empty? | |||
| record.errors[attribute] << N_("The product %{name} has no %{type} repositories with upstream URLs to add to the alternate content source.") % { name: product.name, type: content_type } | |||
| record.errors.add(attribute, N_("%{name} has no %{type} repositories with upstream URLs to add to the alternate content source.") % { name: product.name, type: content_type }) | |||
There was a problem hiding this comment.
Do you think this should be N_ or _?
There was a problem hiding this comment.
Not entirely sure, but documentation suggests N_ for dynamic translations..
https://github.com/grosser/gettext_i18n_rails#unfound-translations-with-rake-gettextfind
There was a problem hiding this comment.
Just tested it out.
With N_
With _
lfu
force-pushed
the
acs_errors_product_msg_36590
branch
from
74aea7a
to
f92d07b
Compare
sjha4
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?